[BUGFIX] Fix EXT:solr route enhancer #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Aug 2, 2023
SolrRoutingMiddleware was limited to indexing processs, but as the SolrFacetMaskAndCombineEnhancer requires this middleware to add the required parameters from the route path, this limitation causes that the route enhancer is ineffective. This commit fixes this issue by reenabling the middleware for frontend requests and also ensures that route paths can be resolved correctly if PageTypeSuffix enhancer is active. Ports: TYPO3-Solr#3742 Relates: TYPO3-Solr#3202 Resolves: TYPO3-Solr#3741
SolrRoutingMiddleware was limited to indexing processs, but as the SolrFacetMaskAndCombineEnhancer requires this middleware to add the required parameters from the route path, this limitation causes that the route enhancer is ineffective. This commit fixes this issue by reenabling the middleware for frontend requests and also ensures that route paths can be resolved correctly if PageTypeSuffix enhancer is active. Relates: TYPO3-Solr#3202 Resolves: TYPO3-Solr#3741
dkd-friedrich
force-pushed
the
bugfix/main/3741-fix_route_enhancer
branch
from
88d6a1a to
b46c926
Compare
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Aug 2, 2023
SolrRoutingMiddleware was limited to indexing processs, but as the SolrFacetMaskAndCombineEnhancer requires this middleware to add the required parameters from the route path, this limitation causes that the route enhancer is ineffective. This commit fixes this issue by reenabling the middleware for frontend requests and also ensures that route paths can be resolved correctly if PageTypeSuffix enhancer is active. Ports: TYPO3-Solr#3742 Relates: TYPO3-Solr#3202 Resolves: TYPO3-Solr#3741
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Aug 2, 2023
SolrRoutingMiddleware was limited to indexing processs, but as the SolrFacetMaskAndCombineEnhancer requires this middleware to add the required parameters from the route path, this limitation causes that the route enhancer is ineffective. This commit fixes this issue by reenabling the middleware for frontend requests and also ensures that route paths can be resolved correctly if PageTypeSuffix enhancer is active. Ports: TYPO3-Solr#3742 Relates: TYPO3-Solr#3202 Resolves: TYPO3-Solr#3741
dkd-kaehm
pushed a commit
that referenced
this pull request
Sep 11, 2023
SolrRoutingMiddleware was limited to indexing processs, but as the SolrFacetMaskAndCombineEnhancer requires this middleware to add the required parameters from the route path, this limitation causes that the route enhancer is ineffective. This commit fixes this issue by reenabling the middleware for frontend requests and also ensures that route paths can be resolved correctly if PageTypeSuffix enhancer is active. Ports: #3742 Relates: #3202 Resolves: #3741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
SolrRoutingMiddleware was limited to indexing processs, but as the SolrFacetMaskAndCombineEnhancer requires this middleware to add the required parameters from the route path, this limitation causes that the route enhancer is ineffective.
This commit fixes this issue by reenabling the middleware for frontend requests and also ensures that route paths can be resolved correctly if PageTypeSuffix enhancer is active.
How to test
Configure route enhancer:
With this commit
Could not resolve page by path "menu.json" and language "de"if requesting a specific page type on root pagesolrRelates: #3202
Resolves: #3741